InternalError_'s Blackmarket trader 3.5.0

Please do not ask when mod authors will update their mods to 3.9.X
Bothering mod authors will lead to warnings and repeat offenses will lead to eventual bans.

Sell your items to a trader for Fleamarket prices

this mod is obviously inspired by 101p's mod, since it does not look like he is updating his mods to the latest releases...
Of course if 101p will release his version for 3.2.0 i will remove this mod, if he wants me to do that


"THE PRICE ON THE ITEM IS NOT HOW MUCH YOU WILL ACTUALLY GET"

"DO NOT TRY TO SELL STACKABLE ITEMS (like ammo) TO BLACKMARKET"

Thumbs Up 2 Heart 2

  • Dead link

  • The link is dead

  • download is not possible, github link is corrupted unfortunately :(

  • hi im having a problem with the latest version. when i sell stuff it just sells the items but i do not get money and i get a infinite loop swirling icon in the right bottom corner. deleted cache, mod, all other mods, user/cache. problem still exists. no error in the serverconsole.

    • What items are u selling, are they fir?

      Do they appear in the prices.csv

    • The same thing. When I try to sell a VOG-17 grenade, an eternal loading appears.

    • Any error messages in the serverlog?

      What other mods do you have installed

  • It looks like I'll have to create an account to give feedback on my problem. Dear Author, I'm using version 1.2.0 of the mod and something went wrong causing the message bar in the bottom right corner of the main screen to be completely empty even though I'm supposed to have a reward from the merchant after completing the quest! No merchant can send me messages or gifts, and I can't initiate chat with them, so help is greatly needed! ;(;(;(;(;(;(;(

    Thumbs Up 1

    • Dear Author, the problem has been solved! He, together with another mod called SystemGift, erroneously deleted the merchant's dialogue under some kind of my operation

  • Can you please explain in more detail how the pricing is determined? Mod advertised to use flea market prices but this doesn't really appear to be the case.


    I did some testing with various items. Here is an example with 1 unit of Soap:

    • Flea market minimum price 23 520 (so around this is what player would expect to get when selling this item)
    • Flea market average price 30 900
    • Flea market maximum price 38 280
    • Therapist trader price 2 450
    • Blackmarket trader showed visually 2 411 on the item (but this is said in mod description not to be valid, so let's disregard)
    • Blackmarket trader transferred 8 216 for the item (which is substantially lower than flea market price)

    • I am using this method from RagfairPriceService


      /**

      * get the dynamic (flea) price for an item

      * Grabs prices from prices.json and stores in class if none currently exist

      * @param itemTpl item template id to look up

      * @returns price in roubles

      */

      public getDynamicPriceForItem(itemTpl: string): number

  • Hey does anyone know how to get this to run for 3.5.0?

    I tried the stuff Alexey wrote in the reviews and got the trader back in the game but i dont get the items buy part to work i cant live without this mod pls help ;(

  • Works great in SPT-AKI 3.4.1!


    However, there should be a giant, unmissable disclaimer saying:


    "THE PRICE ON THE ITEM IS NOT HOW MUCH YOU WILL ACTUALLY GET"

    and maybe also:
    "DO NOT TRY TO SELL STACKABLE ITEMS (like ammo) TO BLACKMARKET"


    So, if you try to sell it to Blackmarket and the listed value is "20k RUB" but the flea value is actually "50k RUB average", you'll actually get around 60k RUB when you click SELL.


    EDIT:

    After some very painful testing, should also have a big disclaimer saying:


    "DO NOT SELL KITTED WEAPONS, THE MOD DOES NOT ADD THE VALUE OF MODS ON IT AND YOU SHOULD TAKE THEM OFF INSTEAD"


    I'm pretty sure it's not the mod's fault either - I don't think the Ragfair module on AKI can price kitted weapons correctly, so fully disassemble them and sell them to Blackmarket instead.

    Heart 1

    • DUDE THANK YOU! I thought for sure the mod was not working but you are 100% right, the listed price is not what it actually sells for.

  • Hey there, i just installed your mod last night when i was doing a fresh mod list for 3.4.1. WHen i got in game i noticed that the blackmarket trader does not have any items in its trading screen. Im unsure where to start looking when it comes to potential issues. any advice would be appreciated!

    • Hi
      The blackmarket does not sell any items by itself.
      This trader is meant to buy all of your FIR items, at the same price as the Fleamarket.
      But it just works instantly, so you dont have to manually create offers for each and every item...

    • Thank you for explaining that, i found out a few hours later when i went to go sell stuff to traders. loving all your mods man keep up the great work!

  • Hi again, I noticed that when selling stacks of Ammo, you only get paid for 1 round instead of the whole stack but the whole stack will disappear. Is this a limitation of the modding API or just a small oversight? Thanks.

    • Did already know that
      I cant fix it. There is a property StackItemCount but it seems like its always 1

      Thumbs Up 1

  • Thanks for the mod, it makes selling your loot a lot easier.

    Btw is it possible for the mod to display the sale price value of the item before the sale? Or a config to set a multiplier for the sale price? It seems it sells much higher than the lowest prices on the flea.

    • No i cannot display the price on the selling table...
      If you want to see the prices for each item, check the configs. there you can enable a csv sheet

      Thumbs Up 1

  • For people wanting to use the mod in 3.3.0 you need to do this:


    Open mod.ts and add this import

    import { EventOutputHolder } from "@spt-aki/routers/EventOutputHolder";

    In both mod.ts and mod.js replace this lines

    const itemEventRouter = this.container.resolve<ItemEventRouter>("ItemEventRouter");

    let output = itemEventRouter.getOutput(sessionID);

    with

    const eventOutputHolder = this.container.resolve<EventOutputHolder>("EventOutputHolder");

    let output = eventOutputHolder.getOutput(sessionID);


    That worked for me, hope it helps!

  • When using this mod, I encountered a problem that the server couldn't run and reports an error as followed.


    The application had a critical error and failed to run

    Exception produced: TypeError: ragfairPriceService.getDynamicPrice is not a function

    Stacktrace:

    TypeError: ragfairPriceService.getDynamicPrice is not a function

    at Blackmarket.resolvePrices (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:128:47)

    at Blackmarket.postDBLoad (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:149:14)

    at PostDBModLoader.executeMods (C:\snapshot\project\obj\loaders\PostDBModLoader.js)

    at PostDBModLoader.onLoad (C:\snapshot\project\obj\loaders\PostDBModLoader.js)

    at App.load (C:\snapshot\project\obj\utils\App.js)

    at C:\snapshot\project\obj\Program.js

    at processTicksAndRejections (node:internal/process/task_queues:96:5)

    at process.runNextTicks [as _tickCallback] (node:internal/process/task_queues:65:3)

    at Function.runMain (pkg/prelude/bootstrap.js:1984:13)

    at node:internal/main/run_main_module:17:47


    The version of the game is SPT-AKT-3.2.5, and I also instill 4 other mod, including armor improvement, two new trader, and enabling Christmas Events. Is the crash caused by mod incopatibility or other reason. I would appiciate it if anyone could solve this problem.

    • Perform the following change to fix the mod for 3.2.5

      Open the mod.js file using notepad, notepadd++, sublime or some other text editor


      Location of the file is here, spt location is where you spt installed:

      C:\sptlocation\user\mods\InternalError-blackmarket-1.1.1\src\mod.js


      go to line 143 which reads:

      const price = ragfairPriceService.getDynamicPrice(id);


      change it to:

      const price = ragfairPriceService.getDynamicPriceForItem(id);


      Save and launch your server.

    • thanks, bro

    • I'm sorry about meeting anothor problem that when selling item to the trader, the game keeps loading and the server reports an error as followed.



      Error: ENOENT: no such file or directory, open 'D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.0\res\blackmarket.jpg'

      Error: ENOENT: no such file or directory, open 'D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.0\res\blackmarket.jpg'

      Error: ENOENT: no such file or directory, open 'D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.0\res\blackmarket.jpg'

      Error: ENOENT: no such file or directory, open 'D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.0\res\blackmarket.jpg'

      [Client Request] /client/trading/api/getTraderAssort/blackmarket

      [Client Request] /client/trading/api/getUserAssortPrice/trader/blackmarket

      [Client Request] /player/health/sync

      [Client Request] /client/game/profile/items/moving

      Blackmarket: Registered 2476 prices

      TypeError: itemEventRouter.getOutput is not a function

      TypeError: itemEventRouter.getOutput is not a function

      at Blackmarket.confirmBlackmarketTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:83:38)

      at Blackmarket.confirmTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:69:29)

      at TradeController.controller.confirmTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:42:29)

      at TradeCallbacks.processTrade (C:\snapshot\project\obj\callbacks\TradeCallbacks.js)

      at TradeItemEventRouter.handleItemEvent (C:\snapshot\project\obj\routers\item_events\TradeItemEventRouter.js)

      at ItemEventRouter.handleEvents (C:\snapshot\project\obj\routers\ItemEventRouter.js)

      at ItemEventCallbacks.handleEvents (C:\snapshot\project\obj\callbacks\ItemEventCallbacks.js)

      at RouteAction.action (C:\snapshot\project\obj\routers\static\ItemEventStaticRouter.js)

      at ItemEventStaticRouter.handleStatic (C:\snapshot\project\obj\di\Router.js)

      at HttpRouter.handleRoute (C:\snapshot\project\obj\routers\HttpRouter.js)

      TypeError: itemEventRouter.getOutput is not a function

      TypeError: itemEventRouter.getOutput is not a function

      at Blackmarket.confirmBlackmarketTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:83:38)

      at Blackmarket.confirmTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:69:29)

      at TradeController.controller.confirmTrading (D:\Game\EFT\user\mods\InternalError-blackmarket-1.1.1\src\mod.js:42:29)

      at TradeCallbacks.processTrade (C:\snapshot\project\obj\callbacks\TradeCallbacks.js)

      at TradeItemEventRouter.handleItemEvent (C:\snapshot\project\obj\routers\item_events\TradeItemEventRouter.js)

      at ItemEventRouter.handleEvents (C:\snapshot\project\obj\routers\ItemEventRouter.js)

      at ItemEventCallbacks.handleEvents (C:\snapshot\project\obj\callbacks\ItemEventCallbacks.js)

      at RouteAction.action (C:\snapshot\project\obj\routers\static\ItemEventStaticRouter.js)

      at ItemEventStaticRouter.handleStatic (C:\snapshot\project\obj\di\Router.js)

      at HttpRouter.handleRoute (C:\snapshot\project\obj\routers\HttpRouter.js)

  • surprised no one else has reported this..
    in version 1.1.1 your traders pic is still pathed to 1.1.0, which leads to trader pic never loading... i originally thought you just never included a pic.. (never really looked)...
    unknown.png

    fixing this line to the right version number fixed the issue

    Crying 1

  • Sometimes when selling a lot of items found in raid and non found in raid, the trader refuses to buy soley found in raid items


    I do have "disableFIRCondition": true,

    • Can you send me your profile and a screenshot?

    • I will but I just updated to 3.2.4 if that matters. I'll try downloading the mod and then trying it again with 3.2.4

  • Hey there is it possible that this could receive a compatibility update with another mod that alters prices for flea market ?


    hub.sp-tarkov.com/files/file/353/

    • What exactly do you mean?

      Cant you sell the mod items at the trader? -> item has no flea price

      Items not FIR? -> If you find the item in raid please provide me with a clip or gif or whatever on discord: InternalError_#3515

      Flea Price Updater should work but ill check in the new version

    • What i mean is that the prices the 2 mod uses is not a match it's 2 different once. Ending up making this mod useless as for the prices.

      U have a price that's not up to date compared to this other mod. Like the mod i ask for compatibility with updates pricing according with online your didn't seem to do that at all. so thing ended up having completely different price on serten items.

    • Okay ill explain you the procedure here:
      When you sell items

      1. Check if its Found in Raid,
      2. Check if it can be sold on flea

      3. Check if there is a flea price for that item

      4. Gives the player the amount that is the cheapest flea offer


      If the item cant be sold on the flea or not fir it will be put back to the stash

      All of this is done while selling

      There are no hardcoded prices for the mod, it always checks the price while selling so if you think there is still an issue, please provide me with the exact mods, configs, settings, version, and profile

    • 4 is the one i say is not working together with the mod i stated otherwise not issue. but that's hard to explain in a good way.

    • Just try to so i can help youplease provide me with the exact mods, configs, settings, version, and profile

  • Can 1.0.3 be used on the 3.1.1 server?

  • Why are there 3 compressed versions of the mod nested in each other?

  • The sell price this mod uses is generated from the AKI code that creates prices within the flea itself. Just edit the mods config.json file to have a negative tax if you want it to give you more money.

    Heart 1

  • I have tested it several times and with some items you get less or much less than when selling at the traders.

    And that the price is not to be seen before, is then also quite unpleasant. I hope that is still adjusted because I do not want to sell the things under value.

    Thinking 1

  • well, does this mod work with Flea Market price updater ? (online plugin or LUA'S FLEA MARKET PRICE UPDATER)

    • It should work fine with LFMPU

    • Unfortunately ,I 've checked several times ,its price doesn't change ,which means there is still something wrong with IBT or LFMPU

      Thinking 1

  • I hope it's the price of the flea market when it's on sale, otherwise it's a bit confusing

    Thinking 1

  • Hello, how does this mod work? I uploaded it for myself and the price of, for example, sugar is not the same/similar as on flea. For comparison sugar at Therapist the selling price is ~10k and the same price at seller from this mod.

    • The prices that are shown are not equal to the effective money you get

    • Meaning ?

    • The amount of money it displays above the "DEAL" button is not the amount of money you will get

  • The mod deleted my money when it glitches out and i have to wait for it to get done reloading then puts my roubles to 1 :/

  • Just a tip, if you put the files in a folder before you zip it, it saves people the hassle of having to make their own folder, and saves you the hassle of telling people to do it when they cry about the mod not working.

    • Gonna do that for my mods preset, whyever it is the standard npm task to zip up a mod

  • are you gonna port the other mods made by him,would love to see the tailor trader and exp trader again. :)

  • do i just make a new folder and name it whatever? or it has to be the exact name as the .zip?

    • name the folder "Blackmarket",

      or install 7zip, and do right click -> 7zip -> Extract files

      Thumbs Up 1