Barter Economy 1.1.0

Another Question. Is that possible to make barter with money as well? Just to have some usage for money. Example: Two items + 10K Roubles for another item.

Afaik, no.

big sad but good to know

You're right. I figured out the issue. I will see when I can get this fixed, unfortunately tarkov modding isn't very high on my priority list right now.

this.config.randomizeAfterUpdates is deprecated. and isnt used anymore. I will mark it as such in the config.

EDIT: probably fixed it, but I dont have time to test right now. If you'd like you can test the update on https://github.com/DeadLeavez/Leaves-BarterEconomy

You have to manually update the mod.ts from the repo, not the latest release. I don't have time right now to test it and post an update.

Tested it on 3.8.3 by copying the relevant lines across that changed in the commit. Unfortunately it looks like it now updates the barter the first time when the bool is false, but then for subsequent refreshes reverts to the rouble barters.

I had a play around with the code, and it seems if this.modifyTrader() isn't called it resets to the rouble barters. I also tried to reinitialize the seeded RNG every time the trader updated with the following, but that also gave me different barters, potentially because the traders are pushed to the array in a different order to the first init?

if ( timeSinceLastRun > 30 )
        {
            if ( this.config.useSeed )
            {
                this.rng = new SeededRandom( this.config.seed );
            }
...[Do rest of updateTraders()]

I'll keep having a play around to see if I can get it to work, since my mates and I really wanted to have a barter economy for a zero-to-hero FIKA playthrough, and will post back here if I can get it working at all.

Update edit:

I set up some initialization in UpdateTraders() so that every trader will have a seed-number, and will go through a fresh init of the RNG that many times, so in theory every time a trader updates it should have the exact same RNG, and that seems to work according to the console logging line, but for some reason the barters *STILL* change around, so I'm wondering if something in the assort is changing. At this point I'm wondering if it's just worth saving the trader's first assort to a JSON and then if non-change is true just copying the json object back across to the trader.assort instead of regenerating it all.

for ( let traderNum = 0; traderNum < this.tradersToUpdate.length; traderNum++ )
            {
                if ( timeNow > this.tradersLastUpdate[ traderNum ] )
                {
                    //NEW CODE STARTS HERE
                    if ( this.config.useSeed )
                    {
                        //Re-init RNG to the same state every time we generate trader
                        this.rng = new SeededRandom( this.config.seed );
                        //Trader nickname to number
                        let nickname = traders[ this.tradersToUpdate[ traderNum ] ].base.nickname
                        //Get a pseudo-unique number for each trader, since assort lists should be different enough to not repeat barters
                        let nameToNum = nickname.length * 37 //Prime
                        //Iterate through RNG that many times to get a kinda new set of RNG per trader
                        for (let rngroll = 0; rngroll < nameToNum; rngroll++)
                        {
                            this.rng.random()
                        }
                        //RNG should now be nameToNum through its seed, ready for trader.
                        this.printColor( `[Barter Economy] Trader ${nickname} has RNG seed ${nameToNum}`, LogTextColor.BLUE );
                    }
                    //NEW CODE ENDS HERE
                    //Update base trader

you could probably do a deep copy of the assort, and then when it updates override with a new copy of the deep copy.

Hey Qwertyalex,

Did you ever manage to fix this?

Not yet unfortunately, but it's something I (hopefully) intend to try to get working at some point. When/if I get it working I'll post it here for peeps, just been busy IRL so not had much time to work on code recently.

If you can elaborate more, I might consider it for the eventual 3.9.0 update.

For example, allowing Therapist to accept medical items and other barter item categories that make sense, while allowing Mechanic to accept gun parts and other barter categories that make sense.

Basically a (optional) whitelist/blacklist per trader to customize what type of items a trader may allow/not allow for barters.

While an interesting idea in theory, and I might make it for 3.9.0 is that there isnt that many high value items in the game, so you might have to make the high-end barter items usable everywhere, or its going to be a mess. But ill def consider it for the next patch.

By default there is a chance that items are available for cash trades, and their prices are based on their trade value and not their original values. If traders were to reset, you'd see other trades for money instead. you can turn this feature off.

thats actually kinda cool

If you could provide the actual error I could possibly look into it. But without it, its difficult.

As for the .txt.lock issue, you could try disabling the follwing

    "dumpTiersToFile": true, //Puts a dump of the tierlist into \mods\Leaves-BarterEconomy\output\

Change that to false

[Barter Economy] Updating Trader:54cb57776803fa99248b456e

scheduled event : 'BarterEconomyUpdateTraders' was not launched successfully.

EPERM: operation not permitted, mkdir 'C:\sptarkov\user\mods\Leaves-BarterEconom

y\output\undefined.lock'

Error: EPERM: operation not permitted, mkdir 'C:\sptarkov\user\mods\Leaves-Barte

rEconomy\output\undefined.lock'

at Object.mkdirSync (node:fs:1380:26)

at Object.mkdirSync (pkg/prelude/bootstrap.js:1639:33)

at Object.mkdir (C:\snapshot\project\node_modules\proper-lockfile\lib\adapte

r.js:15:42)

at acquireLock (C:\snapshot\project\node_modules\proper-lockfile\lib\lockfil

e.js:29:16)

at RetryOperation._fn (C:\snapshot\project\node_modules\proper-lockfile\lib\

lockfile.js:233:13)

at RetryOperation.attempt (C:\snapshot\project\node_modules\retry\lib\retry_

operation.js:112:8)

at C:\snapshot\project\node_modules\proper-lockfile\lib\lockfile.js:232:19

at Object.realpath (C:\snapshot\project\node_modules\proper-lockfile\lib\ada

pter.js:20:13)

at resolveCanonicalPath (C:\snapshot\project\node_modules\proper-lockfile\li

b\lockfile.js:22:16)

at lock (C:\snapshot\project\node_modules\proper-lockfile\lib\lockfile.js:22

4:5)

[Barter Economy] Updating Trader:54cb57776803fa99248b456e

Item c1e82bf27e53d89d2f8a43f5 does not have a barter scheme. Defaulting to item

value 1.

Item c1e82bf27e53d89d2f8a43f5 does not have a loyalty level. Defaulting to 1.

événement programmé : 'BarterEconomyUpdateTraders' n'a pas été lancé avec succès

.

Cannot read properties of undefined (reading '0')

TypeError: Cannot read properties of undefined (reading '0')

at BarterEconomy.isMoneyTrade (C:\sptarkov\user\mods\leaves-bartereconomy\sr

c\mod.ts:544:47)

at BarterEconomy.adjustTrade (C:\sptarkov\user\mods\leaves-bartereconomy\src

\mod.ts:460:20)

at BarterEconomy.modifyTrader (C:\sptarkov\user\mods\leaves-bartereconomy\sr

c\mod.ts:751:22)

at BarterEconomy.updateTraders (C:\sptarkov\user\mods\leaves-bartereconomy\s

rc\mod.ts:132:26)

at OnUpdateMod.onUpdateOverride (C:\sptarkov\user\mods\leaves-bartereconomy\

src\mod.ts:189:50)

at OnUpdateMod.onUpdate (C:\snapshot\src\services\mod\onUpdate\OnUpdateMod.t

s:14:21)

at App.update (C:\snapshot\src\utils\App.ts:82:44)

[Barter Economy] Updating Trader:54cb57776803fa99248b456e

Item c1e82bf27e53d89d2f8a43f5 does not have a barter scheme. Defaulting to item

value 1.

Item c1e82bf27e53d89d2f8a43f5 does not have a loyalty level. Defaulting to 1.

événement programmé : 'BarterEconomyUpdateTraders' n'a pas été lancé avec succès

.

Cannot read properties of undefined (reading '0')

TypeError: Cannot read properties of undefined (reading '0')

at BarterEconomy.isMoneyTrade (C:\sptarkov\user\mods\leaves-bartereconomy\sr

c\mod.ts:544:47)

at BarterEconomy.adjustTrade (C:\sptarkov\user\mods\leaves-bartereconomy\src

\mod.ts:460:20)

at BarterEconomy.modifyTrader (C:\sptarkov\user\mods\leaves-bartereconomy\sr

c\mod.ts:751:22)

at BarterEconomy.updateTraders (C:\sptarkov\user\mods\leaves-bartereconomy\s

rc\mod.ts:132:26)

at OnUpdateMod.onUpdateOverride (C:\sptarkov\user\mods\leaves-bartereconomy\

src\mod.ts:189:50)

at OnUpdateMod.onUpdate (C:\snapshot\src\services\mod\onUpdate\OnUpdateMod.t

s:14:21)

at App.update (C:\snapshot\src\utils\App.ts:82:44)

[Barter Economy] Updating Trader:54cb57776803fa99248b456e

This mod cannot do this unfortunately. There are multiple issues with your suggestion.
First of all, tarkov itself doesnt support buying more than 1 item type at a time. I would basically have to remake the whole trade system in tarkov from the groud up. Something I have no desire to do. Sorry.

Yes, write tag me in the SPT discord,

https://discord.com/channels/8…99922/1224615283738677298

Ok, probably won't be for about a week- as I am dealing with some unforeseen life things that have come up this week

Really excited i found this mod! this is exactly what ive been looking for

You put the ID in the list of at the top of the config file.

    "tradersToBarter"

Because I am a big dum dum. I updated it. Sent it to isaac on discord to test. and then never uploaded. Will upload asap.

Ill look into it soon. But I'm fairly busy lately. so it might not be very quick.

You know what. Possibly. It's not something I'm personally interested in. But Ill take look, and if it seems fairly simple to implement. Ill do it.

If you can to implement it, can I also ask you for a separate price modifier for flea market items?

Ive looked into it. I think its fairly simple to do. I just need to allocate some time to get it done.

Wow, thank you very much))

Love you dude

Yes.

The issue is that ammo would be stupidly expensive. There is no way to set like 50 bullets for one item. So it would be 1 item per bullet. I think the solution would be a trader/or additions to existing traders to add more ammo boxes.

why don't you try and report back?

I could, but I wanted to see if anyone had any experience first before i start testing two mods together that i'm not well versed with and potentially not notice something isn't quite right due to them both having trader changes.

I just want a complete barter economy and you've both made cool as fuck mods ha.

I'll have a try tonight and let you know if anything sticks out.

Awesome. Let me know if you encounter any errors. If it's just tiny incompatibilities Ill see if I can do something about it.

I can't see any issues myself running this along side Softcore. Cheers for creating

Had an issue with Gilded Key Storage, were it'd offer a secondary trade for low tier loot but wanted to keep it as just the single defined trade, think i fixed this turning "copyOverrideExistingBarters" to false, would you recommend this being the best way?

copyOverride does inded create a second barter. It being cheap can be fixed in the newly added trade value override. But only enable copy override (yes I know its on by default), if you actually desire to have two barters per original barter.

If you want to target a specfic trade to prevent it from becoming a new barter, you can do that in the blacklist in config.

The traders will be barter on the flea market. but it does not change anything of the regular flea market offers. Personally i have turned off the flea market.

How do you turn off the raid completely? I locked it behind a lv but if you go into preset builder it ignores this and still allows you to purchase parts through this method.

I did the same thing, but I havent used the preset builder, so I dont know.

Quote

Is it intended that trader offers get randomized each time server starts?

By default: Yes. This and a lot more can be changed in the config.

Quote

I think it would be cool to also have the option of having only vanilla barter trades for real Hardcore runs with currency trades removed(except markers, jammers etc.

Def not a bad idea. But out of scope for this mod.

Thanks I will check out the config options, I already use your loot mods to mimic sort of 'hardcore' challenge possible in live version of the EFT. Thank you for your work!