Featured Item Sell Price 1.2.1

Nope, the mod loops through all of the registered traders.

ah no worries, thanks very much for the reply!

Already answered that in the Note in the description.

ooh ye sorry i read over that my bad

There's a link under "File Details"...

You'll need to be more specific because I can't reproduce that.

If you're using other mods, you'll need to investigate which one might cause a conflict.

ok ty, when i get some time i ill do this tests.

Quote

* i have the broker trader mod

That's exactly the problem, due to how The Broker get items prices, you need to open “TRADERS” tab first.

public static TraderItemPriceData GetBestTraderPriceData(Item item)
        {
            // Shouldn't happen, since tradersList will be assigned post MerchantsList.Show(),
            // before user opens any trader window.
            if (TradersList == null || TradersList?.Count() < 1)
            {
                const string msg = "Trying to PriceManager.getBestPrice while tradersList is empty, this shouldn't happen!";
                //Debug.LogError(msg); doesn't seem to work
                throw new Exception(msg);
            }

            // Explicitly assign Broker to currencies
            // So accepted items are governed by base.json, or setup in the mod.ts.
            if (CurrencyHelper.IsCurrencyId(item.TemplateId) && item.TemplateId != CurrencyHelper.ROUBLE_ID)
            {
                double amount = CurrencyBasePrices[item.TemplateId] * item.StackObjectsCount;
                if (item.TemplateId == CurrencyHelper.DOLLAR_ID) amount *= ModConfig.BuyRateDollar;
                if (item.TemplateId == CurrencyHelper.EURO_ID) amount *= ModConfig.BuyRateEuro;
                int roundedAmount = Convert.ToInt32(Math.Round(amount));
                return new TraderItemPriceData(BROKER_TRADER_ID, ItemPrice.New(CurrencyHelper.ROUBLE_ID, roundedAmount), roundedAmount, roundedAmount, 0, 0);
            }

            // Look for highest paying trader, but get price in roubles,
            // trader appropriate conversion should be done separately, for precision.
            TraderItemPriceData bestTraderPrice = GetTraderItemPriceData(TradersList.First(), item);
            foreach (TraderClass trader in TradersList.Skip(1))
            {
                TraderItemPriceData checkedPrice = GetTraderItemPriceData(trader, item);
                if (checkedPrice.Price == null) continue;
                if (checkedPrice.AmountInRoubles > bestTraderPrice.AmountInRoubles)
                {
                    bestTraderPrice = checkedPrice;
                }
            }
            return bestTraderPrice;
        }

public void Show(IEnumerable<\uE886> tradersList, \uE909 questController, \uEB9A inventoryController, IHealthController healthController, \uE771 session, Profile profile)
        {
            if (tradersList == null)
            {
                throw new Exception(\uEDFD.\uE000(248993));
            }
            this.\uE0B1 = tradersList.ToList<\uE886>();
            this.\uE0B0 = questController;
            this.\uE032 = inventoryController;
            this.\uE08E = healthController;
            this.\uE08D = profile;
            this.\uE033 = session;
            this.ShowGameObject(false);
            this.\uE000();
            this.UI.AddDisposable<\uED34<\uE886, TraderPanel>>(new \uED34<\uE886, TraderPanel>(this.\uE0B1, this._traderPanelTemplate, this._tradersContainer, new Action<\uE886, TraderPanel>(this.\uE002)));
        }

interesting, i learned the prices then i not need the this price mod anymore.

anyway thanks for the resolution

You won't see an error in the console because the console shows only server errors, not client ones. Find the client error in "Logs\log_<timestamp>\<timestamp> errors.log".

2023-06-19 13:31:42.925 -04:00|0.13.0.5.23399|Error|Default|245 errors encountered while deserializing assortment for trader Svetlana

Theres a bunch of No Parent with id xx found for item xx after this but I imagine this first line is the bigger issue?

edit: just saw you uploaded an update on saturday that I don't have yet that might fix for me

2nd edit: updating appears to have fixed it for me, hopefully that was just ops issue as well cheers

that update did fix the problem thank you

This is due to Handy Toolbox using an illegal item ID "YN_Toolbox" for the toolbox.

EXCEPTION: System.FormatException: Could not find any parsable digits.
  at System.ParseNumbers.StringToInt (System.String value, System.Int32 fromBase, System.Int32 flags, System.Int32* parsePos) [0x00166] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.ParseNumbers.StringToInt (System.String value, System.Int32 fromBase, System.Int32 flags) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Convert.ToUInt32 (System.String value, System.Int32 fromBase) [0x00022] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at EFT.MongoID..ctor (System.String id) [0x00009] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at EFT.MongoID.op_Implicit (System.String id) [0x00000] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at GClass2410.smethod_1[T] (T originalItem, EFT.InventoryLogic.IDatabaseIdGenerator idGenerator, System.Boolean skipInvisibleContent, System.Boolean resetSpawnedInSession) [0x0001b] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at GClass2410.CloneItemWithSameId[T] (T originalItem) [0x00000] in <4c96b4e7c0044a5cb491ffd486c41739>:0 

I don't expect you to do this but is it possible for you to update your mod to ignore those "invalid ID's" so the mods used doesn't break? I guess these kind of modded case items will break your mod if using any modded case like Revingly-MICC and Orbitas-AmmoPouch etc? Or am I wrong? Is the problem on those who mod these cases?

I have a similar issue, but it happens with certain weapon presets on modded traders (uses all vanilla guns and attachments as far as i'm aware). AKGuy, AR Reloaded, and Anastasia + Svetlana all have some presents that have broken inspect windows with this mod installed.

This should no longer be an issue in 1.0.2. Can't expect everybody to fix their mods, since changing the illegal item IDs is a breaking change - the game will fail to load the player's profile for existing users of these mods.

Sweet!!! It works great now.

Thanks for the comment! I explained in the description why flea prices are not included.

Ah yes my bad! Missed this part, totally understand though
(maybe in the future it could be a feature that can be enabled/disabled)

This happened to me, too... Guess we'll just have to live without it for now.

Wouldn't work for anything other than 3.5.7, you can download the source code and compile it using 3.5.6 binaries.
Only change needed would be:

using CurrencyUtil = GClass2181;

to:

using CurrencyUtil = GClass2182;

Nope, that's the actual average price specified for it in "Aki_Data/Server/database/templates/prices.json" by SPT-AKI devs.

I assume it's based on the real EFT flea market prices, but it doesn't take into account the fact that there are plenty of "meme prices" there made up by players...

Due to it being a client-side mod, not likely. It references a few classes that might have had different names in previous versions of EFT's main assembly file.

I tried it on 3.5.5, did not work.

You'll need to recompile it for an older version of the game from my source code.

could you provide it? i think there's more people like us that still are in 3.5.5 version

Version 1.0.1 for client 0.13.0.4.22617 (SPT-AKI 3.5.5):

https://www.mediafire.com/file…rice-1.0.1-22617.zip/file

Thank you! My first mod for SPT, but due to my experience with C#, this wasn't difficult.