Item Sell Price 1.6.0

All fine here. Sounds like either a conflict with another mod, or a server mod breaking the game's logic and causing a crash.

Looks like a trader is the conflict..

No, thanks. It's explained in the mod description and already answered in the comments.

Either you don't have the correct client version, or you have some mod that conflicts with this one.

I removed all of the mods I had installed and tried this on its own. My client version is correct. I'll keep playing around with it.

I was having the same issue, I was able to narrow it down to a conflict with Volkov Trader. Item Sell is a BepInEx mod, so I was not able to adjust the mod load order. I just removed the Volkov Trader and it fixed.

Hope this helps.

Considering that this mod gets trader information, a poorly written server mod that adds or modifies traders can definitely cause the game to hang, in which case the server mod has to be fixed.

That fixed it for me too!! Weird that it didn't the first time when I removed everything! Thank you for the assist KlownKiller!!!

By the time you reach Intel Center level 1 or even 2 you likely seen most of the items in the game... Sounds like an awful idea that will turn the mod useless.

Some people (me) have SPT spec-ed out to play very, very different than the normal Live experience. I've built my game into as much of an RPG that it is currently possible to do, I would say; so for me it wouldn't be useless. Appreciate your response though.

that'd be a great idea! I can't ever remember the prices of things so it wouldn't be useless to me and would add more progression and use to the intel center

right?

There's no way to distinguish between an original trader and a custom trader...

use LootValue for that

"An option to show the highest bidder only"

You don't need to search between anything. The sell price is sorted from highest to lowest already, and if you just look at the Selling Price field, it already shows the highest bidder - name and price...

Still clutter the UI for not much in my opinion.
What do you think about a per slot price ?

That would only clutter the UI more than necessary.

I like it exactly as it is. The source code is available for you to customize and compile.

as always choice is king but yeah, can't force you to make stuff, i'm already happy and thankfull you did the mod .

Like what?

Most magz and weapons I will double check in a bit what all but I would say over half the stuff, I don't think its this mods fault but do u perhaps know andy mod conflicts or a recommended load order

You'll have to try to find out.

I have both and it seems to work just fine. For anyone else that wants to know.

Well, it was clearly stated that existing mods are not compatible with 3.8.0.

Well quite a few of em do still work, more or less just leaving a note for people to hold off on this one till its updated/troubleshooting

The links work fine.

Everything is available from the repository as well:

https://dev.sp-tarkov.com/IcyClawz/ClientMods/releases

Thank you so much!

Live flea prices are not the default. I can't assume that the user is using any other mods.

oh okay ?

why it isnt possible ? :x

quick sell never sells to flea is this normal?

What this has to do with my mod though?

i have no clue

but why its not possible to use your mod with the live flea price mod ??

If you look at the folder structure of a mod, you should be able to figure it out. if the zip contains the BepInEx folder with the Plugins folder inside it, or the user folder with the mods folder inside it, its likely that you just extract it to the main spt folder and everything will go where they need to.

I think it is because you 7 zipped it or uncompressed it. try to compress it again In whatever folder you put it in. can you tell me what folder you put the mod in?

I tried putting it in both because at first it was just saying that there was only 6 mods loaded, now it still says i only have 6 mods installed even though i have 14 at least one of which is client sided and its just simply not showing that i have any, I followed the directory paths for both the plugins folder and the mods folder, and no i did not use 7z i just used windows extraction tool 7z is annoying and messes up constantly

it should be ready to put just in your folder and play when you download it. It should be compressed already when you download it. if it still didn't work, maybe it is because your Tarkov is version 3.7.4 or above because this mod only works in 3.7.3 or under. you can see it under the name of this mod. it said you have no mod, don't worry maybe it showed wrong cause mine tells me I don't have mods too but the mod I added did work in the game. Maybe wait a few days for the author of this mod to update it to 3.7.4 or above.

Read the Overview dude, I answered this question too many times.

Quote

Read the Overview dude, I answered this question too many times.

I think you should read my post again. I am talking about this mod by DrakiaXYZ, not base SPT flea market.

No, you should read the Overview. I'm not interested in flea market prices, live or not.

bro are you stupid or something??? it says in the overview that he doesn't show the flee market because the price is just too random. and can IcyClawz, can you update it as soon as possible to 3.7.6 because I love this mod and I need it

Since client version didn't change, and these are client mods, they still work perfectly. Just verified.

Maybe your game broke. All of my mods work fine with 3.7.3 just like they did in 3.7.1, since the game client is still at the same version.

Nope, the mod loops through all of the registered traders.

ah no worries, thanks very much for the reply!

Already answered that in the Note in the description.

ooh ye sorry i read over that my bad

There's a link under "File Details"...

You'll need to be more specific because I can't reproduce that.

If you're using other mods, you'll need to investigate which one might cause a conflict.

ok ty, when i get some time i ill do this tests.

Quote

* i have the broker trader mod

That's exactly the problem, due to how The Broker get items prices, you need to open “TRADERS” tab first.

public static TraderItemPriceData GetBestTraderPriceData(Item item)
        {
            // Shouldn't happen, since tradersList will be assigned post MerchantsList.Show(),
            // before user opens any trader window.
            if (TradersList == null || TradersList?.Count() < 1)
            {
                const string msg = "Trying to PriceManager.getBestPrice while tradersList is empty, this shouldn't happen!";
                //Debug.LogError(msg); doesn't seem to work
                throw new Exception(msg);
            }

            // Explicitly assign Broker to currencies
            // So accepted items are governed by base.json, or setup in the mod.ts.
            if (CurrencyHelper.IsCurrencyId(item.TemplateId) && item.TemplateId != CurrencyHelper.ROUBLE_ID)
            {
                double amount = CurrencyBasePrices[item.TemplateId] * item.StackObjectsCount;
                if (item.TemplateId == CurrencyHelper.DOLLAR_ID) amount *= ModConfig.BuyRateDollar;
                if (item.TemplateId == CurrencyHelper.EURO_ID) amount *= ModConfig.BuyRateEuro;
                int roundedAmount = Convert.ToInt32(Math.Round(amount));
                return new TraderItemPriceData(BROKER_TRADER_ID, ItemPrice.New(CurrencyHelper.ROUBLE_ID, roundedAmount), roundedAmount, roundedAmount, 0, 0);
            }

            // Look for highest paying trader, but get price in roubles,
            // trader appropriate conversion should be done separately, for precision.
            TraderItemPriceData bestTraderPrice = GetTraderItemPriceData(TradersList.First(), item);
            foreach (TraderClass trader in TradersList.Skip(1))
            {
                TraderItemPriceData checkedPrice = GetTraderItemPriceData(trader, item);
                if (checkedPrice.Price == null) continue;
                if (checkedPrice.AmountInRoubles > bestTraderPrice.AmountInRoubles)
                {
                    bestTraderPrice = checkedPrice;
                }
            }
            return bestTraderPrice;
        }

public void Show(IEnumerable<\uE886> tradersList, \uE909 questController, \uEB9A inventoryController, IHealthController healthController, \uE771 session, Profile profile)
        {
            if (tradersList == null)
            {
                throw new Exception(\uEDFD.\uE000(248993));
            }
            this.\uE0B1 = tradersList.ToList<\uE886>();
            this.\uE0B0 = questController;
            this.\uE032 = inventoryController;
            this.\uE08E = healthController;
            this.\uE08D = profile;
            this.\uE033 = session;
            this.ShowGameObject(false);
            this.\uE000();
            this.UI.AddDisposable<\uED34<\uE886, TraderPanel>>(new \uED34<\uE886, TraderPanel>(this.\uE0B1, this._traderPanelTemplate, this._tradersContainer, new Action<\uE886, TraderPanel>(this.\uE002)));
        }

interesting, i learned the prices then i not need the this price mod anymore.

anyway thanks for the resolution

You won't see an error in the console because the console shows only server errors, not client ones. Find the client error in "Logs\log_<timestamp>\<timestamp> errors.log".

2023-06-19 13:31:42.925 -04:00|0.13.0.5.23399|Error|Default|245 errors encountered while deserializing assortment for trader Svetlana

Theres a bunch of No Parent with id xx found for item xx after this but I imagine this first line is the bigger issue?

edit: just saw you uploaded an update on saturday that I don't have yet that might fix for me

2nd edit: updating appears to have fixed it for me, hopefully that was just ops issue as well cheers

that update did fix the problem thank you

This is due to Handy Toolbox using an illegal item ID "YN_Toolbox" for the toolbox.

EXCEPTION: System.FormatException: Could not find any parsable digits.
  at System.ParseNumbers.StringToInt (System.String value, System.Int32 fromBase, System.Int32 flags, System.Int32* parsePos) [0x00166] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.ParseNumbers.StringToInt (System.String value, System.Int32 fromBase, System.Int32 flags) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Convert.ToUInt32 (System.String value, System.Int32 fromBase) [0x00022] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at EFT.MongoID..ctor (System.String id) [0x00009] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at EFT.MongoID.op_Implicit (System.String id) [0x00000] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at GClass2410.smethod_1[T] (T originalItem, EFT.InventoryLogic.IDatabaseIdGenerator idGenerator, System.Boolean skipInvisibleContent, System.Boolean resetSpawnedInSession) [0x0001b] in <4c96b4e7c0044a5cb491ffd486c41739>:0 
  at GClass2410.CloneItemWithSameId[T] (T originalItem) [0x00000] in <4c96b4e7c0044a5cb491ffd486c41739>:0 

I don't expect you to do this but is it possible for you to update your mod to ignore those "invalid ID's" so the mods used doesn't break? I guess these kind of modded case items will break your mod if using any modded case like Revingly-MICC and Orbitas-AmmoPouch etc? Or am I wrong? Is the problem on those who mod these cases?

I have a similar issue, but it happens with certain weapon presets on modded traders (uses all vanilla guns and attachments as far as i'm aware). AKGuy, AR Reloaded, and Anastasia + Svetlana all have some presents that have broken inspect windows with this mod installed.

This should no longer be an issue in 1.0.2. Can't expect everybody to fix their mods, since changing the illegal item IDs is a breaking change - the game will fail to load the player's profile for existing users of these mods.

Sweet!!! It works great now.