Looting Bots 1.3.5 (SPT 3.9.0)

Thanks @hel0t for the update!

Update references to work with SPT 3.9.0.

VirusTotal is showing one of the vendors reporting as malicious (Anity-AVL). This is a false positive, a rescan of version 1.3.4 which had the vendor as passing is now also reporting as malicious

Changes

• Fix ArgumentOutOfRangeException seen when loot scans do not find any lootable items
• Fix issue where one loot result was always omitted when processing results from a loot scan

NoDiscardLimit server mod has been renamed to LootingBots-ServerMod to make it clear that it is related to the LootingBots client mod. Make sure to delete the old Skwizzy-NoDiscardLimit folder in your user/mods!!

Mostly bugfixes and performance improvements. Should be less dips in frame rate when loot scans are executing, however a large scan radius may still cause some small hitching (mostly testing with 500m radius). This is a side effect of the unity Phsyics.OverlapSphereAlloc method used to detect nearby objects, a more robust approach is needed to further improve the scanning performance when using a large detection radius

New Performance Settings (F12)

• Maximum looting bots - Limits the amount of bots that are able to simultaneously run looting logic. A value of 0 represents no limit
• Limit looting by distance to player - Any bot farther than the specified distance in meters will not run any looting logic. A value of 0 represents no limit
  

New Loot Settings (F12)

• Bots always close containers - When enabled, bots will always try to close a container after they have finished looting. If the bot is interrupted while looting, the container may remain open. This is enabled by default
  
• Added dogtags to the list of items that are able to be picked up by bots. By default both PMCs and Scavs will pick up dogtags
• Added armor plates to the list of items that can be picked up by bots. By default PMCs and Scavs will NOT pick up armor plates

Server Mod Changes

• NoDiscardLimit server mod has been renamed to LootingBots-ServerMod to make it clear that it is related to the LootingBots client mod. Make sure to delete the old Skwizzy-NoDiscardLimit folder in your user/mods!!
• Changed default value of pmcSpawnWithLoot to true as it seems like many people prefer pmcs still spawn with their own loot. If using realism, this setting can either be achieved using the Realism Bot Loot changes + LB compatibility options or by setting pmcSpawnWithLoot to false
• Fixed an issue where pmc starting loot was not cleared properly when using pmcSpawnWithLoot: false. Should be compatible with other mods that affect bot loadout generation such as ALP and Realism as long as the NoDiscardLimit mod is loaded after these mods

Client Mod Changes

• Add additional .5 second delay after throw actions to fix issues where bots would sometimes not equip new items after throwing their old item during a swap action
• Fix issue where bots that were interrupted during a loot scan would sometimes continually scan for loot until aggro'd by another bot
• Change initial inventory sort to coroutine to improve performance when LootingBrain is first initialized
• Change loot finding to use Phsyics.OverlapSphereNonAlloc which has better performance with larger data sets
• Prevent bots from sprinting as they approach lootable objects to prevent instances of repeated powersliding
• Only call BotOwner.GoToPoint once when a bot is moving to loot to improve performance.
• Add a little more padding to the destination points when looting to reduce instances where bots are spinning/wiggling while looting because they are too close. Corpse looting still needs some work

Small update with some bugfixes before a meatier logic update. Ty for all the love and support

New Features

• Bots will now close containers after looting is completed, similar to live behavior. If a bot is interrupted or killed during looting, the container may not be closed
• Bots can now merge stackable items. If a bot finds an item that can be stacked and they already have that item in their inventory, the items will be merged if the result of the merge does not exceed the maximum stack size. (example: bot has 40 pst bullets and finds 20 pst, the stacks will NOT be merged)
  

Changes

• Fix issue where player corpses were not being detected as loot
• Filter out items that are in locked slots when looting corpses and armors
• Added value of weapons to the bot's DebugPanel
• Fix issue where bots would not loot loose armor vests
• Fix issue where bots that spawn with 2 weapons would sometimes swap weapons incorrectly, incorrectly throwing their secondary weapons
• Prevent unremovable mods from appearing in loot results when stripping attachments from weapons

New Features

Thanks to Solarint for the following new features:

• Added 3 new methods to the Mod Interop support. GetItemPrice, GetNetLootValue, CheckIfInventoryFull. More info can be found in the interop docs

• Added 3 new options to the Loot Finder settings. These settings will cause bots to ignore loot during loot scans if the loot is not visible by the bot. All disabled by default
  
  • Enable corpse line of sight check
    
  • Enable container line of sight check
  • Enable item line of sight check.

Changes

• Added a new patch to the BotOwner.Dispose method that will remove the BotOwner from the ActiveLootCache when a bot is killed while looting. Should be the root cause of the null reference exceptions seen in the ActiveLootCache

Update GClasses to support AKI 3.8.0

Compatible with AKI 3.7.1 - 3.7.6

Changes

• Prevent caching and finding loot if the BotOwner.name is empty. Should prevent exceptions from being thrown by the ActiveLootCache

Compatible with AKI 3.7.1 - 3.7.6

Changes

• Prevent scavs from looting memory 🤖 . Fixed a memory leak due to excessive regex calls and log message concatenation

There is a known memory leak in this version, working on a fix!

Compatible with AKI 3.7.1 - 3.7.6

For Modders

Thanks to DanW!

Adds support for external commands without requiring LootingBots as a dependency for mods.

Currently the two external commands are:

• Force a loot scan: Forces a bot to scan for loot the next time it is able to do so
• Inhibit looting: Stops a bot from looting and prevents them from scanning for loot for a specified amount of seconds

For more details view the Full documentation

New Features

• New Setting Loot Finder (Timing): Enable examine time - Adds a delay before looting an item to simulate the time it takes for a bot to "uncover (examine)" an item when searching containers, items and corpses. The delay is calculated using the ExamineTime of an object and the AttentionExamineTime of the bot. Without any mods changing these values, it seems like the average examine time is 1 second. Looting should take a bit more time now depending on the amount of items in the container/corpse
• Added a checkbox for PlayerScav to all the Loot Finder settings. Now you can enable/disable looting for player scavs separately from normal scavs

Changes

• Lowered delay at the beginning of container/corpse looting to 2500 ms (simulates UI opening and waiting for the search process to start)
• Renamed Transaction Delay to Delay after taking item and clarified the behavior in the description

• Allow bots to try and loot "searchable" items even if they do not have room to pick them up. Was preventing loose items like backpacks and rigs from being considered as valid loot
• Prevent friendly bots from looting things the player is looting. Enemies can still try to loot the same object as the player
• Hide debugging F12 settings under the "advanced settings" checkbox at the top of the menu
• A bot will now end exit the loot finding logic if the first three items found are not within the acceptable looting range. This is to prevent bots from performing the expensive path distance calculation multiple times unnecessarily as its usually the case that if the first 3 items are not in range then none of the following items will be in range.
• Only show top level items in looting results when searching containers/equipment
• Fixed issue with debug spheres not working

Changes

• When scanning for loot, calculate the distance the bot has to walk in order to reach the loot. If this distance is larger than the loot detection radius, the loot will be considered too far to loot. This should prevent bots on maps like interchange from pathing from the second floor to the parking garage if some loot was detected in the garage with a small vertical distance
• Change old loot value threshold settings to Min loot value threshold
• Scav: Max loot value threshold and PMC: Max loot value threshold - When a value other than 0 is specified, bots will not loot items with a value that exceeds the maximum threshold. By default this is set to `0` for both scav and PMC
• Change Delay between looting setting to Loot scan interval. This now accurately controls the time between loot scans for a bot. When a bot completes a scan or leaves the looting logic, the bot will wait the specified amount of seconds before scanning again. Previously there were 2 timers and they were not playing nicely together
  
• Default Loot scan interval has been increased: 6 seconds -> 10 seconds
  
• Allow bots to pick up stacks of money
• Sort the initial results from a loot scan by distance, greatly reducing the amount of times needed to iterate through the results (Thanks Drakia)
  
• Move loot finding calculations into a coroutine to avoid blocking thread with heavy calculations
  
• Do not allow the looting layer to activate if the bot is healing
  
• Do not allow the looting layer to activate if the bot type is not enabled for any looting. Previously bots not enabled for looting would still scan but not loot